Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In MLEBABecLap::compGrad, add missing call to addInhomogNeumannFlux #3441

Merged
merged 1 commit into from
Jul 23, 2023
Merged

In MLEBABecLap::compGrad, add missing call to addInhomogNeumannFlux #3441

merged 1 commit into from
Jul 23, 2023
+2 −0

Conversation

cgilet
Copy link
Contributor

@cgilet cgilet commented Jul 23, 2023

For inhomogeneous Neumann BC, we convert the inhomogeneous part into RHS and treat the BC as homogeneous Neumann during the solve. Thus, the flux is zero there before inhomogeneous flux is added.

Summary

Additional background

Checklist

The proposed changes:

  • [ x] fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@cgilet
In MLEBABecLap::compGrad, add missing call to addInhomogNeumannFlux
b3722bb 
For inhomogeneous Neumann BC, we convert the inhomogeneous part
into RHS and treat the BC as homogeneous Neumann during the solve.
Thus, the flux is zero there before inhomogeneous flux is added.
@cgilet cgilet requested a review from WeiqunZhang July 23, 2023 00:36
@WeiqunZhang WeiqunZhang merged commit 6faf7ee into AMReX-Codes:development Jul 23, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgilet @WeiqunZhang